Skip to content

l1: move anvil test util into single use-case #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

giladchase
Copy link
Contributor

Only this test now needs to initialize multiple anvil instances, since
it's testing l1 node-switching. All other use cases were previously
converted to use the more robust anvil base layer.

@reviewable-StarkWare
Copy link

This change is Reviewable

@giladchase giladchase marked this pull request as ready for review July 6, 2025 10:06
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from d19c918 to dec9f14 Compare July 6, 2025 10:07
@giladchase giladchase force-pushed the gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ branch from 57a37c0 to 403c543 Compare July 6, 2025 10:07
@giladchase giladchase changed the base branch from gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ to graphite-base/7791 July 28, 2025 12:56
@giladchase giladchase force-pushed the graphite-base/7791 branch from 403c543 to c42070b Compare July 28, 2025 12:57
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from dec9f14 to 06def12 Compare July 28, 2025 12:57
@giladchase giladchase changed the base branch from graphite-base/7791 to gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test July 28, 2025 12:58
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from c42070b to febb6eb Compare July 28, 2025 14:49
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 06def12 to 4111efc Compare July 28, 2025 14:49
Copy link
Contributor

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from febb6eb to ba4385e Compare August 4, 2025 04:59
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 4111efc to 77f593a Compare August 4, 2025 04:59
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from ba4385e to 6077cfc Compare August 4, 2025 05:09
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 67cb5fc to 1a87b9a Compare August 4, 2025 12:30
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch 2 times, most recently from 020fdce to dac99f6 Compare August 4, 2025 12:50
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 1a87b9a to 5b765c4 Compare August 4, 2025 12:50
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from dac99f6 to ca06fa0 Compare August 4, 2025 13:51
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch 2 times, most recently from bc81b56 to 6015c2d Compare August 5, 2025 05:13
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from ca06fa0 to 44da249 Compare August 5, 2025 05:13
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 6015c2d to 9276af2 Compare August 5, 2025 08:09
@giladchase giladchase force-pushed the gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test branch from 44da249 to 6cb5ec7 Compare August 5, 2025 08:09
@giladchase giladchase changed the base branch from gilad/07-06-l1_convert_events_from_other_contracts_test_into_integration_test to graphite-base/7791 August 5, 2025 12:04
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from 9276af2 to aa7b3d8 Compare August 5, 2025 14:02
@giladchase giladchase changed the base branch from graphite-base/7791 to gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ August 5, 2025 14:03
@graphite-app graphite-app bot changed the base branch from gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ to graphite-base/7791 August 6, 2025 13:09
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from aa7b3d8 to bd03968 Compare August 6, 2025 13:15
@giladchase giladchase changed the base branch from graphite-base/7791 to gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ August 6, 2025 13:15
@giladchase giladchase changed the base branch from gilad/07-06-l1_remove_unused_test-utils_in_favor_of_anvilbaselayer_ to main August 6, 2025 14:59
Only this test now needs to initialize multiple anvil instances, since
it's testing l1 node-switching. All other use cases were previously
converted to use the more robust anvil base layer.
@giladchase giladchase force-pushed the gilad/07-06-l1_move_anvil_test_util_into_single_use-case branch from bd03968 to 28495c3 Compare August 6, 2025 14:59
Copy link

graphite-app bot commented Aug 6, 2025

Merge activity

  • Aug 6, 3:00 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@giladchase giladchase added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit 1ac60fb Aug 6, 2025
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants