Skip to content

apollo_metrics: add a struct that increments a metric counter when it goes out of scope #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guy-starkware
Copy link
Contributor

@guy-starkware guy-starkware commented Jul 3, 2025

This is useful when you have a complicated function that has many ways to return an error or panic, and you'd like to increment an error counter in all cases except when the function returns successfully in the end.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@guy-starkware guy-starkware marked this pull request as ready for review July 3, 2025 11:07
Copy link

github-actions bot commented Aug 3, 2025

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 3, 2025
@github-actions github-actions bot closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants