-
Notifications
You must be signed in to change notification settings - Fork 61
apollo_l1_provider: test consume tx event #7699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 06-30-apollo_l1_provider_add_handling_for_transactionconsumed_event
Are you sure you want to change the base?
apollo_l1_provider: test consume tx event #7699
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @giladchase)
e3e621e
to
0667563
Compare
0756c83
to
8fde2ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)
crates/apollo_l1_provider/src/l1_provider_tests.rs
line 959 at r1 (raw file):
assert_eq!(status, InvalidValidationStatus::ConsumedOnL1OrUnknown.into()); }
You probably also wanna check the panic-flow for double consume.
Also probably consuming canceled/rejected txs, consume should always work.
Also committing a consume-scheduled tx (not very likely but still possible).
Lots of flows to think about 😵
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
No description provided.