Skip to content

apollo_l1_provider: test consume tx event #7699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 06-30-apollo_l1_provider_add_handling_for_transactionconsumed_event
Choose a base branch
from

Conversation

AlonLStarkWare
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@AlonLStarkWare AlonLStarkWare force-pushed the 07-01-apollo_l1_provider_test_consume_tx_event branch from e3e621e to 0667563 Compare July 2, 2025 11:30
@AlonLStarkWare AlonLStarkWare force-pushed the 06-30-apollo_l1_provider_add_handling_for_transactionconsumed_event branch from 0756c83 to 8fde2ec Compare July 2, 2025 11:30
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AlonLStarkWare)


crates/apollo_l1_provider/src/l1_provider_tests.rs line 959 at r1 (raw file):

    assert_eq!(status, InvalidValidationStatus::ConsumedOnL1OrUnknown.into());
}

You probably also wanna check the panic-flow for double consume.

Also probably consuming canceled/rejected txs, consume should always work.

Also committing a consume-scheduled tx (not very likely but still possible).

Lots of flows to think about 😵

Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants