Skip to content

refactor(starknet_integration_tests): wrap the storage handles in a sub-struct #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nadin-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

nadin-Starkware commented Mar 24, 2025

@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_pass_storage_config_directly_to_create_node_config branch from d91aba8 to b181f7b Compare March 24, 2025 10:06
@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_wrap_the_storage_handles_in_a_sub-struct branch from 6d20b11 to 158fdea Compare March 24, 2025 10:06
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions


crates/starknet_integration_tests/src/integration_test_manager.rs line 81 at r1 (raw file):

    state_sync_index: usize,

    // Handlers for the storage files, maintained so the files are not deleted. Since

Please delete

Code quote:

r

crates/starknet_integration_tests/src/integration_test_manager.rs line 82 at r1 (raw file):

    // Handlers for the storage files, maintained so the files are not deleted. Since
    // these are only maintained to avoid dropping the handlers, private visibility suffices, and

same

Code quote:

r

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_pass_storage_config_directly_to_create_node_config branch from b181f7b to 0007b95 Compare March 24, 2025 20:39
@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_wrap_the_storage_handles_in_a_sub-struct branch from 158fdea to 9601c70 Compare March 25, 2025 06:56
@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_pass_storage_config_directly_to_create_node_config branch from 0007b95 to b3d6b16 Compare March 25, 2025 06:56
@nadin-Starkware nadin-Starkware changed the base branch from 03-24-refactor_starknet_integration_tests_pass_storage_config_directly_to_create_node_config to main March 25, 2025 07:32
@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_wrap_the_storage_handles_in_a_sub-struct branch from 9601c70 to 98d1647 Compare March 25, 2025 07:33
Copy link

graphite-app bot commented Mar 25, 2025

Merge activity

  • Mar 25, 3:34 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@nadin-Starkware nadin-Starkware force-pushed the 03-24-refactor_starknet_integration_tests_wrap_the_storage_handles_in_a_sub-struct branch from 98d1647 to db0db5e Compare March 25, 2025 09:07
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 3a831ef Mar 26, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants