-
Notifications
You must be signed in to change notification settings - Fork 52
refactor(starknet_integration_tests): wrap the storage handles in a sub-struct #5212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(starknet_integration_tests): wrap the storage handles in a sub-struct #5212
Conversation
d91aba8
to
b181f7b
Compare
6d20b11
to
158fdea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions
crates/starknet_integration_tests/src/integration_test_manager.rs
line 81 at r1 (raw file):
state_sync_index: usize, // Handlers for the storage files, maintained so the files are not deleted. Since
Please delete
Code quote:
r
crates/starknet_integration_tests/src/integration_test_manager.rs
line 82 at r1 (raw file):
// Handlers for the storage files, maintained so the files are not deleted. Since // these are only maintained to avoid dropping the handlers, private visibility suffices, and
same
Code quote:
r
b181f7b
to
0007b95
Compare
158fdea
to
9601c70
Compare
0007b95
to
b3d6b16
Compare
9601c70
to
98d1647
Compare
Merge activity
|
98d1647
to
db0db5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
No description provided.