chore(blockifier): limit l1 gas resources #5207
Conversation
|
This change is |
noaov1
force-pushed
the
noa/limit_gas_for_l1_handler
branch
4 times, most recently
from
bf5aaf9 to
aa3aa62
Compare
noaov1
requested review from
dorimedini-starkware,
meship-starkware and
Yoni-Starkware
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @Yoni-Starkware)
noaov1
force-pushed
the
noa/allow_limit_gas_for_l1
branch
from
894a2ae to
04c7de6
Compare
noaov1
force-pushed
the
noa/limit_gas_for_l1_handler
branch
from
aa3aa62 to
85cd108
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
crates/blockifier/src/transaction/transaction_execution.rs line 165 at r2 (raw file):
// Enforce resource bounds. FeeCheckReport::check_all_gas_amounts_within_bounds(&l1_handler_bounds, &receipt.gas)?;
what happens if this fails? tx is rejected, right? no reverts on L1 handlers?
Code quote:
FeeCheckReport::check_all_gas_amounts_within_bounds(&l1_handler_bounds, &receipt.gas)?;
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1)
crates/blockifier/src/transaction/transaction_execution.rs line 165 at r2 (raw file):
Previously, dorimedini-starkware wrote…
what happens if this fails? tx is rejected, right? no reverts on L1 handlers?
Right
a discussion (no related file):
Wait for the Py side
crates/blockifier/src/fee/fee_checks.rs line 127 at r2 (raw file):
} pub fn check_all_gas_amounts_within_bounds(
Just moved?
crates/blockifier/src/transaction/transaction_execution.rs line 157 at r2 (raw file):
let execute_call_info = self.run_execute(state, &mut context, &mut remaining_gas)?; let l1_handler_payload_size = self.payload_size(); let receipt = TransactionReceipt::from_l1_handler(
Are you fixing this in another PR?
Code quote:
receipt = TransactionReceipt::from_l1_handle
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yoni-Starkware)
crates/blockifier/src/fee/fee_checks.rs line 127 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Just moved?
And it became public, which is why it was moved.
crates/blockifier/src/transaction/transaction_execution.rs line 157 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Are you fixing this in another PR?
Fixing what? Do you mean this?
(preliminary PR).
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)
noaov1
force-pushed
the
noa/limit_gas_for_l1_handler
branch
from
85cd108 to
611ab10
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yoni-Starkware)
a discussion (no related file):
Previously, Yoni-Starkware (Yoni) wrote…
Wait for the Py side
Done.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yoni-Starkware)
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1.
Reviewable status:
No description provided.