chore(starknet_l1_provider): add lazy sync height test

[giladchase]

Also add util for flushing the fake l1 client: its currently just
buffering the calls it gets, and needs a manual flush.

[reviewable-StarkWare]

This change is 

[giladchase]

• chore(starknet_l1_provider): add lazy sync height test #5188 👈 (View in Graphite)
• fix(starknet_l1_provider): flow test consistency #5187
• fix(starknet_l1_provider): off-by-one flow test #5186
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArniStarkware]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @alonh5)

[elintul]

Reviewed 1 of 2 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @alonh5)

---

crates/starknet_l1_provider/tests/startup_flows.rs line 209 at r2 (raw file):

#[tokio::test]
async fn bootstrap_delayed_sync_state_with_catch_up() {

Not sure I understand the scenario from this name, consider a docstring.

Code quote:

bootstrap_delayed_sync_state_with_catch_up

---

crates/starknet_l1_provider/tests/startup_flows.rs line 212 at r2 (raw file):

    if !in_ci() {
        return;
    }

Remind me, why?

Code quote:

    if !in_ci() {
        return;
    }

---

crates/starknet_l1_provider/tests/startup_flows.rs line 213 at r2 (raw file):

        return;
    }
    configure_tracing().await;

Why manually? :(

Code quote:

configure_tracing().await;

[giladchase]

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @alonh5 and @elintul)

---

crates/starknet_l1_provider/tests/startup_flows.rs line 209 at r2 (raw file):

Previously, elintul (Elin) wrote…

Not sure I understand the scenario from this name, consider a docstring.

Srry, is this better?

---

crates/starknet_l1_provider/tests/startup_flows.rs line 212 at r2 (raw file):

Previously, elintul (Elin) wrote…

Remind me, why?

Local users might not have anvil installed.

---

crates/starknet_l1_provider/tests/startup_flows.rs line 213 at r2 (raw file):

Previously, elintul (Elin) wrote…

Why manually? :(

Looks like without this i don't get tracing in the test :(

[elintul]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_l1_provider/tests/startup_flows.rs line 249 at r3 (raw file):

    // **Commit** a few blocks. These should get backlogged since they are post-sync-height.
    // Sleeps are sprinkled in to give the async task a couple shots at attempting to get the sync

✨❤️

Code quote:

sprinkled

---

crates/starknet_l1_provider/tests/startup_flows.rs line 283 at r3 (raw file):

    assert_eq!(
        l1_provider.current_height,
        sync_height.unchecked_next().unchecked_next().unchecked_next()

A better alternative? :(

Code quote:

sync_height.unchecked_next().unchecked_next().unchecked_next()

[giladchase]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_l1_provider/tests/startup_flows.rs line 283 at r3 (raw file):

Previously, elintul (Elin) wrote…

A better alternative? :(

How about this?

[elintul]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_l1_provider/tests/startup_flows.rs line 283 at r3 (raw file):

Previously, giladchase wrote…

How about this?

Looks good, thanks!

[ArniStarkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[elintul]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)