feat(starknet_os): implement load deprecated class inner hint

[rotem-starkware]

feat(starknet_os): copy load_deprecated_class_inner hint implementation from moonsong's repo

feat(starknet_os): implement load deprecated class inner hint

[reviewable-StarkWare]

This change is 

[rotem-starkware]

• feat(starknet_os): implement load deprecated class inner hint #5108 👈 (View in Graphite)
• feat(starknet_os): implement LoadCairoObject trait for DeprecatedContractClass #5107
• feat(starknet_os): implement LoadCairoObject trait for EntryPointV0 #5106
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 50 at r2 (raw file):

pub(crate) fn load_deprecated_class_inner<S: StateReader>(
    HintArgs { hint_processor, vm, exec_scopes, ids_data, ap_tracking, .. }: HintArgs<'_, S>,

Suggestion:

hint_processor, vm, exec_scopes, ids_data, ap_tracking, constants, ..

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 53 at r2 (raw file):

) -> OsHintResult {
    let deprecated_class_iter = exec_scopes
        .get_mut_ref::<IntoIter<Felt, ContractClass>>(Scope::CompiledClassFacts.into())?;

right?

Suggestion:

ClassHash

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 59 at r2 (raw file):

    exec_scopes.insert_value(Scope::CompiledClassHash.into(), class_hash);
    // TODO(Rotem): see if we can avoid cloning here.
    exec_scopes.insert_value(Scope::CompiledClass.into(), deprecated_class.clone());

Please look at the cairo code and see if that insertion is needed. I suspect that only this hint needs the var compiled_class to use it as an arg for get\_deprecated\_contract\_class\_struct

Code quote:

exec_scopes.insert_value(Scope::CompiledClass.into(), deprecated_class.clone());

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 63 at r2 (raw file):

    let dep_class_base = vm.add_memory_segment();
    let dep_class_version: &str = Const::DeprecatedCompiledClassVersion.into();
    let constants = HashMap::from([(String::from(dep_class_version), Felt::from(0))]);

you should use the constants var in HintArgs :)

Code quote:

    let dep_class_version: &str = Const::DeprecatedCompiledClassVersion.into();
    let constants = HashMap::from([(String::from(dep_class_version), Felt::from(0))]);

[rotem-starkware]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 53 at r2 (raw file):

Previously, nimrod-starkware wrote…

right?

Done.

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 59 at r2 (raw file):

Previously, nimrod-starkware wrote…

Please look at the cairo code and see if that insertion is needed. I suspect that only this hint needs the var compiled_class to use it as an arg for get\_deprecated\_contract\_class\_struct

It is used in the hint load_deprecated_class

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 63 at r2 (raw file):

Previously, nimrod-starkware wrote…

you should use the constants var in HintArgs :)

Done.

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 50 at r2 (raw file):

pub(crate) fn load_deprecated_class_inner<S: StateReader>(
    HintArgs { hint_processor, vm, exec_scopes, ids_data, ap_tracking, .. }: HintArgs<'_, S>,

Done.

[nimrod-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[yoavGrs]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rotem-starkware)

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 54 at r3 (raw file):

        .get_mut_ref::<IntoIter<Felt252, GenericDeprecatedCompiledClass>>(vars::scopes::COMPILED_CLASS_FACTS)?;

    let (class_hash, deprecated_class) = deprecated_class_iter.next().unwrap();

Return Err. Something like OsHintError::EndOfIterator(deprecated_class)?

Code quote:

.unwrap()

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 58 at r4 (raw file):

    exec_scopes.insert_value(Scope::CompiledClassHash.into(), class_hash);
    // TODO(Rotem): see if we can avoid cloning here.

Why about moving this insertion after the 'load_into'?

Code quote:

// TODO(Rotem): see if we can avoid cloning here.

[rotem-starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 54 at r3 (raw file):

Previously, yoavGrs wrote…

Return Err. Something like OsHintError::EndOfIterator(deprecated_class)?

Done.

---

crates/starknet_os/src/hints/hint_implementation/deprecated_compiled_class/implementation.rs line 58 at r4 (raw file):

Previously, yoavGrs wrote…

Why about moving this insertion after the 'load_into'?

Done.

[yoavGrs]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

[yoavGrs]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)