Skip to content

chore(starknet_os): fix enum definitions to make the block input an a… #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

meship-starkware
Copy link
Collaborator

…rray pr pass CI

@reviewable-StarkWare
Copy link

This change is Reviewable

@meship-starkware meship-starkware force-pushed the meship/fix_enum_def_to_pass_block_input_ci branch from 692211a to 200b632 Compare March 18, 2025 13:23
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meship/fix_enum_def_to_pass_block_input_ci branch from 200b632 to 24ad94b Compare March 18, 2025 14:27
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@meship-starkware meship-starkware force-pushed the meship/fix_enum_def_to_pass_block_input_ci branch 2 times, most recently from 6615b18 to c0965f5 Compare March 19, 2025 06:13
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/starknet_os/src/hints/enum_definition.rs line 1708 at r4 (raw file):

        (from_bytes(contract.contract_hash), segments.add(), contract.nonce))
    for address, contract in block_input.contracts.items()
}"#

add your TODO here too please

Code quote:

    (
        InitializeStateChanges,
        initialize_state_changes,
        indoc! {r#"from starkware.python.utils import from_bytes

initial_dict = {
    address: segments.gen_arg(
        (from_bytes(contract.contract_hash), segments.add(), contract.nonce))
    for address, contract in block_input.contracts.items()
}"#

@meship-starkware meship-starkware force-pushed the meship/fix_enum_def_to_pass_block_input_ci branch from c0965f5 to 8e724bb Compare March 19, 2025 07:26
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os/src/hints/enum_definition.rs line 1708 at r4 (raw file):

Previously, dorimedini-starkware wrote…

add your TODO here too please

Done.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meship/fix_enum_def_to_pass_block_input_ci branch from 8e724bb to c8ace9b Compare March 19, 2025 08:28
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 1292c7d Mar 19, 2025
10 checks passed
@meship-starkware meship-starkware deleted the meship/fix_enum_def_to_pass_block_input_ci branch March 19, 2025 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants