-
Notifications
You must be signed in to change notification settings - Fork 52
chore(starknet_os): fix enum definitions to make the block input an a… #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_os): fix enum definitions to make the block input an a… #5022
Conversation
692211a
to
200b632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
200b632
to
24ad94b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
6615b18
to
c0965f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/starknet_os/src/hints/enum_definition.rs
line 1708 at r4 (raw file):
(from_bytes(contract.contract_hash), segments.add(), contract.nonce)) for address, contract in block_input.contracts.items() }"#
add your TODO here too please
Code quote:
(
InitializeStateChanges,
initialize_state_changes,
indoc! {r#"from starkware.python.utils import from_bytes
initial_dict = {
address: segments.gen_arg(
(from_bytes(contract.contract_hash), segments.add(), contract.nonce))
for address, contract in block_input.contracts.items()
}"#
c0965f5
to
8e724bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os/src/hints/enum_definition.rs
line 1708 at r4 (raw file):
Previously, dorimedini-starkware wrote…
add your TODO here too please
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
8e724bb
to
c8ace9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
…rray pr pass CI