Skip to content

refactor(starknet_sequencer_node): move dump_config_file to sequencer node #5021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

nadin-Starkware
Copy link
Collaborator

No description provided.

@nadin-Starkware nadin-Starkware marked this pull request as ready for review March 18, 2025 13:00
@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware force-pushed the 03-18-refactor_starknet_sequencer_node_move_configpointersmap_to_starknet_sequencer_node branch from 8519ee4 to 1e07fdf Compare March 18, 2025 13:03
@nadin-Starkware nadin-Starkware force-pushed the 03-18-refactor_starknet_sequencer_node_move_configpointersmap_to_starknet_sequencer_node branch from 1e07fdf to c20c073 Compare March 18, 2025 13:24
@nadin-Starkware nadin-Starkware force-pushed the 03-18-refactor_starknet_sequencer_node_move_configpointersmap_to_starknet_sequencer_node branch from c20c073 to c5c1fa2 Compare March 18, 2025 13:42
@nadin-Starkware nadin-Starkware changed the title chore( refactor(starknet_sequencer_node): move ConfigPointersMap to starknet_sequencer_node Mar 18, 2025
@nadin-Starkware nadin-Starkware changed the title refactor(starknet_sequencer_node): move ConfigPointersMap to starknet_sequencer_node refactor(starknet_sequencer_node): move dump_config_file to sequencer node Mar 18, 2025
@nadin-Starkware nadin-Starkware force-pushed the 03-18-refactor_starknet_sequencer_node_move_configpointersmap_to_starknet_sequencer_node branch from c5c1fa2 to c59fcde Compare March 18, 2025 14:02
Copy link

github-actions bot commented Mar 18, 2025

Artifacts upload workflows:

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the base branch from 03-18-refactor_starknet_sequencer_node_move_configpointersmap_to_starknet_sequencer_node to main March 18, 2025 17:53
Copy link

graphite-app bot commented Mar 18, 2025

Merge activity

  • Mar 18, 1:59 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 1ff9ca1 Mar 18, 2025
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants