Skip to content

chore(starknet_os): fix hints of simplified compiled class hash #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

Yoni-Starkware
Copy link
Collaborator

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/starknet_os/src/hints/enum_definition.rs line 391 at r1 (raw file):

        "is_segment_used_callback": is_segment_used_callback

    })"#}

this hint is already implemented: please update the implementation to reflect your changes

Code quote:

        bytecode_segment_structure,
        indoc! {r#"
    vm_enter_scope({
        "bytecode_segment_structure": bytecode_segment_structures[ids.compiled_class_fact.hash],
        "is_segment_used_callback": is_segment_used_callback

    })"#}

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/os/simplify-compiled-class-hints branch from 21abd8b to 481f7f0 Compare March 18, 2025 15:43
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)


crates/starknet_os/src/hints/enum_definition.rs line 391 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this hint is already implemented: please update the implementation to reflect your changes

Added a TODO on @nimrod-starkware - supporting this new hint is almost all the work that's left for this file.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit 197b407 Mar 18, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants