feat(starknet_os): implement assign bytecode segments hint

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

• feat(starknet_os): implement assert end of bytecode segments hint #5005
• feat(starknet_os): implement assign bytecode segments hint #5004 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

    } else {
        unreachable!("assign_bytecode_segments should not be called on a leaf node.");
    }

I think technically this can happen, right?
I cannot - in a context-free way - see why the else is unreachable...
how about this?

Suggestion:

    match bytecode_segment_structure {
        BytecodeSegmentNode::InnerNode(node) => {
            exec_scopes.insert_value(Scope::BytecodeSegments.into(), node.segments.into_iter());
            Ok(())
        }
        BytecodeSegmentNode::Leaf(_) => Err(OsHintError::AssignedLeafBytecode)
    }

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

Previously, dorimedini-starkware wrote…

I think technically this can happen, right?
I cannot - in a context-free way - see why the else is unreachable...
how about this?

yes, technically, it is possible, but within the flow of the OS code, it's not.
PTAL here , if the variant is a leaf then the function will return early and won't reach that hint.
(returning an error is also fine IMO, just want to clarify this should be unreachable)

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

Previously, nimrod-starkware wrote…

yes, technically, it is possible, but within the flow of the OS code, it's not.
PTAL here , if the variant is a leaf then the function will return early and won't reach that hint.
(returning an error is also fine IMO, just want to clarify this should be unreachable)

let's go with errors, we are writing a library here

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

Previously, dorimedini-starkware wrote…

let's go with errors, we are writing a library here

Done.

[dorimedini-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

Previously, nimrod-starkware wrote…

Done.

please use match - it protects against addition of another variant without handling it correctly

[nimrod-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs)

---

crates/starknet_os/src/hints/hint_implementation/compiled_class/implementation.rs line 39 at r1 (raw file):

Previously, dorimedini-starkware wrote…

please use match - it protects against addition of another variant without handling it correctly

Done.

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)