Skip to content

Conversation

@TomerStarkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TomerStarkware TomerStarkware requested a review from orizi December 14, 2025 15:19
@TomerStarkware TomerStarkware marked this pull request as ready for review December 14, 2025 15:19
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-lowering/src/specialization.rs line 40 at r1 (raw file):

        type_id: TypeId<'db>,
        values: Vec<SpecializationArg<'db>>,
    },

any reason not to just have these as part of the struct - and just match on the type?

Code quote:

    Tuple(Vec<SpecializationArg<'db>>),
    FixedSizeArray {
        type_id: TypeId<'db>,
        values: Vec<SpecializationArg<'db>>,
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants