Skip to content

Conversation

@sashass1315
Copy link
Contributor

The previous comment stated that the constructor “Find[s] all contracts.”, but SierraCasmRunner::new does not perform any discovery. It takes a precomputed map of class_hash to ContractInfo and stores it. Contract discovery is implemented externally in cairo-lang-starknet (e.g., find_contracts + get_contracts_info) and callers such as the CLI and test runner supply the map. The updated comment clarifies this ownership boundary to prevent confusion and reflects the actual design and usages in casm_run where the runner only reads from starknet_contracts_info.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/cairo-lang-runner/src/lib.rs line 193 at r1 (raw file):

    ) -> Result<Self, RunnerError> {
        // Receive precomputed contract info (class_hash -> ContractInfo). Discovery is performed by
        // the caller.

was just a leftover most likely - just remove the comment.

@sashass1315
Copy link
Contributor Author

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion

crates/cairo-lang-runner/src/lib.rs line 193 at r1 (raw file):

    ) -> Result<Self, RunnerError> {
        // Receive precomputed contract info (class_hash -> ContractInfo). Discovery is performed by
        // the caller.

was just a leftover most likely - just remove the comment.

removed

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sashass1315)

@orizi orizi enabled auto-merge November 20, 2025 20:53
@orizi orizi added this pull request to the merge queue Nov 20, 2025
Merged via the queue into starkware-libs:main with commit 51fadf2 Nov 20, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants