-
Notifications
You must be signed in to change notification settings - Fork 652
Updated version of cairo-vm. #8718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
TomerStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomerStarkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @Stavbe)
Stavbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-runner/src/casm_run/mod.rs line 2343 at r1 (raw file):
runner.run_until_pc(end, hint_processor).map_err(CairoRunError::from)?; runner.end_run(true, false, hint_processor, false).map_err(CairoRunError::from)?;
I am not sure what this function is used for, but I saw the config contain proof_mode= true. If you need it for proof with stwo, fill_holes needs to be true.
crates/cairo-lang-runner/src/casm_run/mod.rs line 2344 at r1 (raw file):
runner.run_until_pc(end, hint_processor).map_err(CairoRunError::from)?; runner.end_run(true, false, hint_processor, false).map_err(CairoRunError::from)?; runner.relocate(true, true).map_err(CairoRunError::from)?;
This does match the old behavior, but make sure we actually need to relocate the trace otherwise it’s just a waste of runtime.
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @Stavbe)
crates/cairo-lang-runner/src/casm_run/mod.rs line 2343 at r1 (raw file):
Previously, Stavbe wrote…
I am not sure what this function is used for, but I saw the config contain proof_mode= true. If you need it for proof with stwo, fill_holes needs to be true.
no actual proof running here.
crates/cairo-lang-runner/src/casm_run/mod.rs line 2344 at r1 (raw file):
Previously, Stavbe wrote…
This does match the old behavior, but make sure we actually need to relocate the trace otherwise it’s just a waste of runtime.
the ap from the trace is read sometimes - so it is required.
a discussion (no related file):
@Stavbe we possibly need to change cairo-execute though.
Stavbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stavbe reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
b1917c8 to
676fcd2
Compare

No description provided.