Skip to content

Conversation

@orizi
Copy link
Collaborator

@orizi orizi commented Nov 20, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

orizi commented Nov 20, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@orizi orizi marked this pull request as ready for review November 20, 2025 11:48
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@TomerStarkware reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware and @Stavbe)

Copy link

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-runner/src/casm_run/mod.rs line 2343 at r1 (raw file):

    runner.run_until_pc(end, hint_processor).map_err(CairoRunError::from)?;
    runner.end_run(true, false, hint_processor, false).map_err(CairoRunError::from)?;

I am not sure what this function is used for, but I saw the config contain proof_mode= true. If you need it for proof with stwo, fill_holes needs to be true.


crates/cairo-lang-runner/src/casm_run/mod.rs line 2344 at r1 (raw file):

    runner.run_until_pc(end, hint_processor).map_err(CairoRunError::from)?;
    runner.end_run(true, false, hint_processor, false).map_err(CairoRunError::from)?;
    runner.relocate(true, true).map_err(CairoRunError::from)?;

This does match the old behavior, but make sure we actually need to relocate the trace otherwise it’s just a waste of runtime.

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @Stavbe)


crates/cairo-lang-runner/src/casm_run/mod.rs line 2343 at r1 (raw file):

Previously, Stavbe wrote…

I am not sure what this function is used for, but I saw the config contain proof_mode= true. If you need it for proof with stwo, fill_holes needs to be true.

no actual proof running here.


crates/cairo-lang-runner/src/casm_run/mod.rs line 2344 at r1 (raw file):

Previously, Stavbe wrote…

This does match the old behavior, but make sure we actually need to relocate the trace otherwise it’s just a waste of runtime.

the ap from the trace is read sometimes - so it is required.


a discussion (no related file):
@Stavbe we possibly need to change cairo-execute though.

Copy link

@Stavbe Stavbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stavbe reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

@orizi orizi force-pushed the orizi/11-20-updated_version_of_cairo-vm branch from b1917c8 to 676fcd2 Compare November 20, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants