-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use only RpcProvider #857
docs: use only RpcProvider #857
Conversation
✅ Deploy Preview for starknetjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest documenting that new RpcProvider({ nodeUrl: constants.NetworkName.SN_GOERLI })
and new RpcProvider()
are also possible and note that when using them a random public node will be selected, but also advise that using a specific nodeUrl
is the better approach.
It might also make sense to mostly use one of those two options in most of the documentation or something like new RpcProvider({ nodeUrl: `${someNodeUrl}` })
and use specific nodeUrl
values within www/docs/guides/connect_network.md
to simplify documentation maintenance (e.g. the Nethermind URLs will soon change).
This is the new Juno link, but didn't test it yet if it's live: https://free-rpc.nethermind.io/mainnet-juno/v0_5 |
english wording Co-authored-by: Ivan Pavičić <ivan.pavicic@live.com>
It's live (I have a script to batch check quickly a list of nodes). Is it a difference with |
yes I think they will turn off the old link... so if it works, maybe best to update to the new one! |
Honestly, I wasn't aware of this random access. |
I completely rewrote |
Co-authored-by: Ivan Pavičić <ivan.pavicic@live.com>
Co-authored-by: Ivan Pavičić <ivan.pavicic@live.com>
🎉 This PR is included in version 5.24.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation and Resolution
Following removal of Starknet sequencers, users shall only use
RpcSequencer
.The guides are here updated in accordance.
It's also the opportunity to migrate in the guides from Pythonic Devnet to Starknet-devnet-rs.
Usage related changes
N/A
Development related changes
N/A
Checklist: