-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add events util tests #1218
Merged
ivpavici
merged 10 commits into
starknet-io:develop
from
lukasaric:chore/utils-events-tests
Sep 5, 2024
Merged
chore: add events util tests #1218
ivpavici
merged 10 commits into
starknet-io:develop
from
lukasaric:chore/utils-events-tests
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasaric
commented
Sep 5, 2024
penovicp
approved these changes
Sep 5, 2024
ivpavici
approved these changes
Sep 5, 2024
🎉 This issue has been resolved in version 6.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Write
events
util tests to improve tests coverage. That includes tests for these utiils:isAbiEvent
getAbiEvents
parseEvents
parseUDCEvent
It resolves: #1217
RPC version (if applicable)
n.a
Usage related changes
n.a
Development related changes
isObject
will not be covered here since it is moved to a different util in #1212Checklist: