Skip to content

Commit

Permalink
ci: restore devnet tests
Browse files Browse the repository at this point in the history
  • Loading branch information
penovicp committed Nov 22, 2023
1 parent 862d4d1 commit 1843e3c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ jobs:
# TODO - periodically check if conditional services are supported; https://github.com/actions/runner/issues/822
services:
devnet:
image: ${{ inputs.use-rpc-devnet && 'shardlabs/starknet-devnet-rs:c7b5fde8fb46f8e7d498f63cc44beb0bd2ddd85e-seed0' || inputs.use-seq-devnet && 'shardlabs/starknet-devnet:0.6.3-seed0' || '' }}
image: ${{ inputs.use-rpc-devnet && 'shardlabs/starknet-devnet-rs:638a11adc96d443d03b04fc0d5c13c8a1e3bfc5b-amd-seed0' || inputs.use-seq-devnet && 'shardlabs/starknet-devnet:0.6.3-seed0' || '' }}
# image: ${{ (inputs.use-rpc-devnet || inputs.use-seq-devnet) && 'shardlabs/starknet-devnet:0.6.3-seed0' || '' }}
# image: shardlabs/starknet-devnet-rs:c7b5fde8fb46f8e7d498f63cc44beb0bd2ddd85e-seed0
# image: shardlabs/starknet-devnet-rs:638a11adc96d443d03b04fc0d5c13c8a1e3bfc5b-amd-seed0
ports:
- 5050:5050

Expand Down
10 changes: 5 additions & 5 deletions __tests__/jestGlobalSetup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* ref: order of execution jestGlobalSetup.ts -> jest.setup.ts -> fixtures.ts
*/

import { getDefaultNodeUrl } from '../src';
import { BaseUrl } from '../src/constants';

type DevnetStrategy = {
Expand Down Expand Up @@ -156,10 +155,11 @@ const verifySetup = (final?: boolean) => {
if (final) throw new Error('TEST_ACCOUNT_PRIVATE_KEY env is not provided');
else warnings.push('TEST_ACCOUNT_PRIVATE_KEY env is not provided!');
}
if (!process.env.TEST_RPC_URL) {
process.env.TEST_RPC_URL = getDefaultNodeUrl();
console.warn('TEST_RPC_URL env is not provided');
}
// TODO: revise after Sequencer removal
// if (!process.env.TEST_RPC_URL) {
// process.env.TEST_RPC_URL = getDefaultNodeUrl();
// console.warn('TEST_RPC_URL env is not provided');
// }

if (warnings.length > 0) {
console.log('\x1b[33m', warnings.join('\n'), '\x1b[0m');
Expand Down

0 comments on commit 1843e3c

Please sign in to comment.