fix: connection modal overrides gsw selection modal #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
pushed a commit
that referenced
this pull request
May 3, 2022
### [1.3.1-dev.4](v1.3.1-dev.3...v1.3.1-dev.4) (2022-05-03) ### 🔧 Fixes * connection modal overrides gsw selection modal ([#175](#175)) ([73b1f21](73b1f21))
Author
|
🎉 This PR is included in version 1.3.1-dev.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
dan-ziv
pushed a commit
that referenced
this pull request
May 4, 2022
## [1.4.0](v1.3.0...v1.4.0) (2022-05-04) ### 🔧 Fixes * cancel toFixed when format balances ([#172](#172)) ([2906e3e](2906e3e)) * connection modal overrides gsw selection modal ([#175](#175)) ([73b1f21](73b1f21)) * temporary disable max button ([#173](#173)) ([1d3038d](1d3038d)) * update app state on accountsChanged event ([#176](#176)) ([3161cc9](3161cc9)) * update text for the attempt to deposit more than the allowable amount ([#174](#174)) ([d8f3da8](d8f3da8)) ### 🧩 Features * add asset to SN wallet after a successful deposit ([#171](#171)) ([30d8ec3](30d8ec3))
Author
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
In case the user selected a wallet but the wallet is locked or the dapp is not connected (i.e. not yet authorized), the promise will not be resolved. so I don't have a way to differentiate between the selection of the wallet and the actual connection to the wallet
Solution:
Use
connectAPI fromget-starknet-walletwhich returns the actual selected wallet from the listChecklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is