Skip to content

fix: cancel toFixed when format balances #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: fix: Wallet L1 & L2 is connected auto connect
merged 3 commits into from
May 3, 2022
Merged

fix: cancel toFixed when format balances #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
359a40e
fix
May 2, 2022
3a86af1
fix tests
May 2, 2022
66d28ef
fix test
May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/__tests__/utils/wallet.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import utils from '../../utils';
const {formatBalance, shortenAddress, shortenBalance} = utils.wallet;

describe('formatBalance', () => {
it('should format balance to 5 digits precision', () => {
expect(formatBalance(1.222243232)).toEqual(1.22224);
expect(formatBalance(3000.232143123212)).toEqual(3000.23214);
expect(formatBalance(10.000000001)).toEqual(10);
it('should format balance as string', () => {
expect(formatBalance(1.222243232)).toEqual('1.222243232');
expect(formatBalance(3000.232143123212)).toEqual('3000.232143123212');
expect(formatBalance(10.000000001)).toEqual('10.000000001');
});

it('should handle exponential balances', () => {
Expand Down
6 changes: 1 addition & 5 deletions src/utils/wallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
export const formatBalance = balance => {
if (typeof balance === 'number') {
balance = fromExponential(balance);
return typeof balance === 'string' ? balance : parseFloat(balance.toFixed(5));
}
return 'N/A';
return typeof balance === 'number' ? String(fromExponential(balance)) : 'N/A';
};

export const shortenBalance = balance => {
Expand Down