Skip to content

Commit

Permalink
PCMCIA: sa1111: jornada720: no need to disable IRQs around sa1111_set_io
Browse files Browse the repository at this point in the history
sa1111_set_io() already contains the necessary locking within itself
to safely change the state of a set of GPIOs.  There's no need for
callers to protect this by disabling IRQs themselves.

Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Feb 21, 2012
1 parent 65c77dc commit e2adbec
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/pcmcia/sa1100_jornada720.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,8 @@ jornada720_pcmcia_configure_socket(struct soc_pcmcia_socket *skt, const socket_s
}

ret = sa1111_pcmcia_configure_socket(skt, state);
if (ret == 0) {
unsigned long flags;

local_irq_save(flags);
if (ret == 0)
sa1111_set_io(s->dev, pa_dwr_mask, pa_dwr_set);
local_irq_restore(flags);
}

return ret;
}
Expand Down

0 comments on commit e2adbec

Please sign in to comment.