Skip to content

Commit

Permalink
coccinelle: Add rules to find str_hi{gh}_lo{w}() replacements
Browse files Browse the repository at this point in the history
As other rules done, we add rules for str_hi{gh}_lo{w}()
to check the relative opportunities.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
  • Loading branch information
Hongbo Li authored and JuliaLawall committed Sep 28, 2024
1 parent 8a0236b commit d4c7544
Showing 1 changed file with 42 additions and 0 deletions.
42 changes: 42 additions & 0 deletions scripts/coccinelle/api/string_choices.cocci
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,45 @@ e << str_false_true_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_false_true(%s)" % e)
@str_hi_lo depends on patch@
expression E;
@@
(
- ((E) ? "hi" : "lo")
+ str_hi_lo(E)
)

@str_hi_lo_r depends on !patch exists@
expression E;
position P;
@@
(
* ((E@P) ? "hi" : "lo")
)

@script:python depends on report@
p << str_hi_lo_r.P;
e << str_hi_lo_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_hi_lo(%s)" % e)
@str_high_low depends on patch@
expression E;
@@
- ((E) ? "high" : "low")
+ str_high_low(E)

@str_high_low_r depends on !patch exists@
expression E;
position P;
@@
* ((E@P) ? "high" : "low")

@script:python depends on report@
p << str_high_low_r.P;
e << str_high_low_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_high_low(%s)" % e)

0 comments on commit d4c7544

Please sign in to comment.