Skip to content

Commit

Permalink
dmaengine: add private header file
Browse files Browse the repository at this point in the history
Add a local private header file to contain definitions and declarations
which should only be used by DMA engine drivers.

We also fix linux/dmaengine.h to use LINUX_DMAENGINE_H to guard against
multiple inclusion.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
[imx-sdma.c & mxs-dma.c]
Tested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
  • Loading branch information
Russell King - ARM Linux authored and Vinod Koul committed Mar 13, 2012
1 parent 4d4e58d commit d2ebfb3
Show file tree
Hide file tree
Showing 25 changed files with 51 additions and 2 deletions.
2 changes: 2 additions & 0 deletions drivers/dma/amba-pl08x.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@
#include <linux/slab.h>
#include <asm/hardware/pl080.h>

#include "dmaengine.h"

#define DRIVER_NAME "pl08xdmac"

static struct amba_driver pl08x_amba_driver;
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/at_hdmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <linux/of_device.h>

#include "at_hdmac_regs.h"
#include "dmaengine.h"

/*
* Glossary
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/coh901318.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <mach/coh901318.h>

#include "coh901318_lli.h"
#include "dmaengine.h"

#define COHC_2_DEV(cohc) (&cohc->chan.dev->device)

Expand Down
10 changes: 10 additions & 0 deletions drivers/dma/dmaengine.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/*
* The contents of this file are private to DMA engine drivers, and is not
* part of the API to be used by DMA engine users.
*/
#ifndef DMAENGINE_H
#define DMAENGINE_H

#include <linux/dmaengine.h>

#endif
1 change: 1 addition & 0 deletions drivers/dma/dw_dmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <linux/slab.h>

#include "dw_dmac_regs.h"
#include "dmaengine.h"

/*
* This supports the Synopsys "DesignWare AHB Central DMA Controller",
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/ep93xx_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@

#include <mach/dma.h>

#include "dmaengine.h"

/* M2P registers */
#define M2P_CONTROL 0x0000
#define M2P_CONTROL_STALLINT BIT(0)
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/fsldma.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include <linux/dmapool.h>
#include <linux/of_platform.h>

#include "dmaengine.h"
#include "fsldma.h"

#define chan_dbg(chan, fmt, arg...) \
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/imx-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#include <mach/dma-v1.h>
#include <mach/hardware.h>

#include "dmaengine.h"

struct imxdma_channel {
struct imxdma_engine *imxdma;
unsigned int channel;
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/imx-sdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
#include <mach/dma.h>
#include <mach/hardware.h>

#include "dmaengine.h"

/* SDMA registers */
#define SDMA_H_C0PTR 0x000
#define SDMA_H_INTR 0x004
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/intel_mid_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
#include <linux/intel_mid_dma.h>
#include <linux/module.h>

#include "dmaengine.h"

#define MAX_CHAN 4 /*max ch across controllers*/
#include "intel_mid_dma_regs.h"

Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/ioat/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
#include "registers.h"
#include "hw.h"

#include "../dmaengine.h"

int ioat_pending_level = 4;
module_param(ioat_pending_level, int, 0644);
MODULE_PARM_DESC(ioat_pending_level,
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/ioat/dma_v2.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
#include "registers.h"
#include "hw.h"

#include "../dmaengine.h"

int ioat_ring_alloc_order = 8;
module_param(ioat_ring_alloc_order, int, 0644);
MODULE_PARM_DESC(ioat_ring_alloc_order,
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/iop-adma.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@

#include <mach/adma.h>

#include "dmaengine.h"

#define to_iop_adma_chan(chan) container_of(chan, struct iop_adma_chan, common)
#define to_iop_adma_device(dev) \
container_of(dev, struct iop_adma_device, common)
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/ipu/ipu_idmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

#include <mach/ipu.h>

#include "../dmaengine.h"
#include "ipu_intern.h"

#define FS_VF_IN_VALID 0x00000002
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/mpc512x_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@

#include <linux/random.h>

#include "dmaengine.h"

/* Number of DMA Transfer descriptors allocated per channel */
#define MPC_DMA_DESCRIPTORS 64

Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/mv_xor.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#include <linux/platform_device.h>
#include <linux/memory.h>
#include <plat/mv_xor.h>

#include "dmaengine.h"
#include "mv_xor.h"

static void mv_xor_issue_pending(struct dma_chan *chan);
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/mxs-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
#include <mach/dma.h>
#include <mach/common.h>

#include "dmaengine.h"

/*
* NOTE: The term "PIO" throughout the mxs-dma implementation means
* PIO mode of mxs apbh-dma and apbx-dma. With this working mode,
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/pch_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
#include <linux/module.h>
#include <linux/pch_dma.h>

#include "dmaengine.h"

#define DRV_NAME "pch-dma"

#define DMA_CTL0_DISABLE 0x0
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/pl330.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
#include <linux/scatterlist.h>
#include <linux/of.h>

#include "dmaengine.h"

#define NR_DEFAULT_DESC 16

enum desc_status {
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/ppc4xx/adma.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
#include <asm/dcr.h>
#include <asm/dcr-regs.h>
#include "adma.h"
#include "../dmaengine.h"

enum ppc_adma_init_code {
PPC_ADMA_INIT_OK = 0,
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/shdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#include <linux/kdebug.h>
#include <linux/spinlock.h>
#include <linux/rculist.h>

#include "dmaengine.h"
#include "shdma.h"

/* DMA descriptor control */
Expand Down
1 change: 1 addition & 0 deletions drivers/dma/ste_dma40.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

#include <plat/ste_dma40.h>

#include "dmaengine.h"
#include "ste_dma40_ll.h"

#define D40_NAME "dma40"
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/timb_dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@

#include <linux/timb_dma.h>

#include "dmaengine.h"

#define DRIVER_NAME "timb-dma"

/* Global DMA registers */
Expand Down
2 changes: 2 additions & 0 deletions drivers/dma/txx9dmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/scatterlist.h>

#include "dmaengine.h"
#include "txx9dmac.h"

static struct txx9dmac_chan *to_txx9dmac_chan(struct dma_chan *chan)
Expand Down
4 changes: 2 additions & 2 deletions include/linux/dmaengine.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
* The full GNU General Public License is included in this distribution in the
* file called COPYING.
*/
#ifndef DMAENGINE_H
#define DMAENGINE_H
#ifndef LINUX_DMAENGINE_H
#define LINUX_DMAENGINE_H

#include <linux/device.h>
#include <linux/uio.h>
Expand Down

0 comments on commit d2ebfb3

Please sign in to comment.