Skip to content

Commit

Permalink
as: fix antic_expire check
Browse files Browse the repository at this point in the history
Fix units mismatch (jiffies vs msecs) in as-iosched.c, spotted by Xiaoning
Ding <dingxn@cse.ohio-state.edu>.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Nick Piggin authored and Linus Torvalds committed May 8, 2007
1 parent e97cb3e commit c6a632a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions block/as-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ static void as_update_iohist(struct as_data *ad, struct as_io_context *aic,
static int as_close_req(struct as_data *ad, struct as_io_context *aic,
struct request *rq)
{
unsigned long delay; /* milliseconds */
unsigned long delay; /* jiffies */
sector_t last = ad->last_sector[ad->batch_data_dir];
sector_t next = rq->sector;
sector_t delta; /* acceptable close offset (in sectors) */
Expand All @@ -578,11 +578,11 @@ static int as_close_req(struct as_data *ad, struct as_io_context *aic,
if (ad->antic_status == ANTIC_OFF || !ad->ioc_finished)
delay = 0;
else
delay = ((jiffies - ad->antic_start) * 1000) / HZ;
delay = jiffies - ad->antic_start;

if (delay == 0)
delta = 8192;
else if (delay <= 20 && delay <= ad->antic_expire)
else if (delay <= (20 * HZ / 1000) && delay <= ad->antic_expire)
delta = 8192 << delay;
else
return 1;
Expand Down

0 comments on commit c6a632a

Please sign in to comment.