Skip to content

Commit

Permalink
[POWERPC] Cleanup pseries smp initialisation code
Browse files Browse the repository at this point in the history
Move some extern declarations from setup.c into the new pseries.h.
While we're at it, provide dummy implementations for !SMP, to avoid
cluttering the C file with more #ifdefs.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
mpe authored and paulusmack committed Feb 14, 2007
1 parent 577830b commit 8feaeca
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
8 changes: 8 additions & 0 deletions arch/powerpc/platforms/pseries/pseries.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,12 @@ struct pt_regs;
extern int pSeries_system_reset_exception(struct pt_regs *regs);
extern int pSeries_machine_check_exception(struct pt_regs *regs);

#ifdef CONFIG_SMP
extern void smp_init_pseries_mpic(void);
extern void smp_init_pseries_xics(void);
#else
static inline smp_init_pseries_mpic(void) { };
static inline smp_init_pseries_xics(void) { };
#endif

#endif /* _PSERIES_PSERIES_H */
6 changes: 0 additions & 6 deletions arch/powerpc/platforms/pseries/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@
#endif

/* move those away to a .h */
extern void smp_init_pseries_mpic(void);
extern void smp_init_pseries_xics(void);
extern void find_udbg_vterm(void);

int fwnmi_active; /* TRUE if an FWNMI handler is present */
Expand Down Expand Up @@ -272,18 +270,14 @@ static void __init pseries_discover_pic(void)
#ifdef CONFIG_KEXEC
ppc_md.kexec_cpu_down = pseries_kexec_cpu_down_mpic;
#endif
#ifdef CONFIG_SMP
smp_init_pseries_mpic();
#endif
return;
} else if (strstr(typep, "ppc-xicp")) {
ppc_md.init_IRQ = xics_init_IRQ;
#ifdef CONFIG_KEXEC
ppc_md.kexec_cpu_down = pseries_kexec_cpu_down_xics;
#endif
#ifdef CONFIG_SMP
smp_init_pseries_xics();
#endif
return;
}
}
Expand Down
1 change: 1 addition & 0 deletions arch/powerpc/platforms/pseries/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
#include <asm/vdso_datapage.h>

#include "plpar_wrappers.h"
#include "pseries.h"

#ifdef DEBUG
#include <asm/udbg.h>
Expand Down

0 comments on commit 8feaeca

Please sign in to comment.