Skip to content

Commit

Permalink
tracing/probe: Fix null pointer dereference
Browse files Browse the repository at this point in the history
BUG: KASAN: null-ptr-deref in trace_probe_cleanup+0x8d/0xd0
Read of size 8 at addr 0000000000000000 by task syz-executor.0/9746
trace_probe_cleanup+0x8d/0xd0
free_trace_kprobe.part.14+0x15/0x50
alloc_trace_kprobe+0x23e/0x250

Link: http://lkml.kernel.org/r/1565220563-980-1-git-send-email-danielliu861@gmail.com

Fixes: e3dc9f8 ("tracing/probe: Add trace_event_call accesses APIs")
Signed-off-by: Xinpeng Liu <danielliu861@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
  • Loading branch information
xinpengliu authored and rostedt committed Aug 31, 2019
1 parent 595a438 commit 19a58ce
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kernel/trace/trace_probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,8 @@ void trace_probe_cleanup(struct trace_probe *tp)
for (i = 0; i < tp->nr_args; i++)
traceprobe_free_probe_arg(&tp->args[i]);

kfree(call->class->system);
if (call->class)
kfree(call->class->system);
kfree(call->name);
kfree(call->print_fmt);
}
Expand Down

0 comments on commit 19a58ce

Please sign in to comment.