remove rust-cypto dependency, fix issuse 2404 3254 #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #3609 +/- ##
==========================================
- Coverage 29.29% 29.00% -0.28%
==========================================
Files 589 589
Lines 49864 49864
Branches 23450 23450
==========================================
- Hits 14601 14458 -143
+ Misses 21264 21257 -7
- Partials 13999 14149 +150
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was
linked to
issues
Aug 4, 2022
Benchmark for 99d2ef1Click to view benchmark
|
JerryKwan
reviewed
Aug 4, 2022
There was a problem hiding this comment.
@nkysg
Seems like you are using tiny-keccak to replace rust-crypto, but the latest commit to tini-keccak is 2 years ago. Not sure if it is maintained.
When reading the codes in Move language, we noticed that they are using crate sha2 to do some hash algorithms.
https://docs.rs/sha2/latest/sha2/
https://github.com/RustCrypto/hashes
jolestar
reviewed
Aug 4, 2022
@JerryKwan we should use lib sha3 or tiny-keccak, our HashValue compute hash implement sha3 algo。 #[cfg(not(feature = "avx512f"))]
pub fn sha3_256_of(buffer: &[u8]) -> Self {
let mut sha3 = Sha3::v256();
sha3.update(buffer);
HashValue::from_keccak(sha3)
}HashValue code is port from diem-crypto |
Benchmark for 49c0531Click to view benchmark
|
nkysg
requested review from
xudon9,
nanne007,
yourmoonlight,
sanlee42 and
LemonHX
as code owners
Benchmark for 9712801Click to view benchmark
|
jolestar
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
fix issue
#2404
#3254
Issue Number: N/A
What is the new behavior?
Other information