-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add diskcheck #3598
add diskcheck #3598
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3598 +/- ##
==========================================
+ Coverage 28.79% 28.94% +0.15%
==========================================
Files 591 591
Lines 50351 50413 +62
Branches 23722 23757 +35
==========================================
+ Hits 14496 14586 +90
- Misses 21670 21736 +66
+ Partials 14185 14091 -94
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: jiangying <krivergo3@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看看怎么测试一下
这个测试用例我想了几天,可能写不出来测试用例。只能扔到服务器上去跑着测试了。 |
至少本地得模拟个环境测试下,比如把那个磁盘限制改一下,然后看看能不能启动。 |
是哦,我想着是到服务器上编译。然后写满服务器。这样也行。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看没问题了,@nkysg 看看
@YusongWang 需要 resolve 下 conflicts |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #3562
What is the new behavior?
Other information