Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diskcheck #3598

Merged
merged 12 commits into from
Aug 8, 2022
Merged

add diskcheck #3598

merged 12 commits into from
Aug 8, 2022

Conversation

YouNeedWork
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3562

What is the new behavior?

Other information

@YouNeedWork YouNeedWork requested a review from sanlee42 as a code owner August 2, 2022 04:04
@YouNeedWork YouNeedWork marked this pull request as draft August 2, 2022 04:04
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #3598 (145f4e7) into master (e526915) will increase coverage by 0.15%.
The diff coverage is 42.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3598      +/-   ##
==========================================
+ Coverage   28.79%   28.94%   +0.15%     
==========================================
  Files         591      591              
  Lines       50351    50413      +62     
  Branches    23722    23757      +35     
==========================================
+ Hits        14496    14586      +90     
- Misses      21670    21736      +66     
+ Partials    14185    14091      -94     
Flag Coverage Δ
unittests 28.94% <42.86%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/tasks/mod.rs 26.22% <0.00%> (-0.08%) ⬇️
types/src/system_events.rs 69.57% <0.00%> (-1.54%) ⬇️
...ync/src/block_connector/block_connector_service.rs 28.37% <36.74%> (+4.16%) ⬆️
node/src/node.rs 14.18% <63.16%> (+3.87%) ⬆️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-8.95%) ⬇️
vm/natives/src/account.rs 18.75% <0.00%> (-6.25%) ⬇️
network-p2p/src/peer_info.rs 43.53% <0.00%> (-4.66%) ⬇️
vm/vm-runtime/src/metrics.rs 25.00% <0.00%> (-4.16%) ⬇️
commons/accumulator/src/tree_store/mock.rs 28.58% <0.00%> (-2.85%) ⬇️
vm/types/src/token/token_code.rs 34.53% <0.00%> (-2.38%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e526915...145f4e7. Read the comment docs.

@nkysg nkysg self-requested a review August 2, 2022 07:17
@YouNeedWork YouNeedWork marked this pull request as ready for review August 2, 2022 08:58
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看怎么测试一下

sync/src/block_connector/block_connector_service.rs Outdated Show resolved Hide resolved
sync/src/block_connector/block_connector_service.rs Outdated Show resolved Hide resolved
@YouNeedWork
Copy link
Contributor Author

看看怎么测试一下

这个测试用例我想了几天,可能写不出来测试用例。只能扔到服务器上去跑着测试了。

node/src/node.rs Outdated Show resolved Hide resolved
@jolestar
Copy link
Member

jolestar commented Aug 5, 2022

看看怎么测试一下

这个测试用例我想了几天,可能写不出来测试用例。只能扔到服务器上去跑着测试了。

至少本地得模拟个环境测试下,比如把那个磁盘限制改一下,然后看看能不能启动。

@YouNeedWork
Copy link
Contributor Author

看看怎么测试一下

这个测试用例我想了几天,可能写不出来测试用例。只能扔到服务器上去跑着测试了。

至少本地得模拟个环境测试下,比如把那个磁盘限制改一下,然后看看能不能启动。

是哦,我想着是到服务器上编译。然后写满服务器。这样也行。

node/src/node.rs Outdated Show resolved Hide resolved
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看没问题了,@nkysg 看看

@jolestar jolestar linked an issue Aug 6, 2022 that may be closed by this pull request
@jolestar
Copy link
Member

jolestar commented Aug 6, 2022

@YusongWang 需要 resolve 下 conflicts

@jolestar jolestar merged commit f3c9687 into starcoinorg:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] insuffient disk space warning
4 participants