Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add job token & storage env for job #940

Merged

Conversation

anda-ren
Copy link
Member

Description

  • add job token env for job
  • add storage env for job

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Aug 19, 2022
@anda-ren anda-ren self-assigned this Aug 19, 2022
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldenxinxing goldenxinxing merged commit 909a0bc into star-whale:feat/controller_support_new_job Aug 19, 2022
anda-ren added a commit that referenced this pull request Aug 25, 2022
* tune job and task impl

* feat(controller): add job token & storage env for job  (#940)

job token env;s3 env

* add project info for task

* add env for k8s core container

* test(e2e): modify e2e deployment from docker compose to minikube (#948)

e2e test

* feat(controller): storage prefix env (#941)

swds path prefix injection

Co-authored-by: star <15031259256@163.com>

* fix(controller): fix dataset upload error (#958)

* error fix

* fix protocol un match error

Co-authored-by: star <15031259256@163.com>

* change task container entrypoint

* fix(controller): fix sql error (#977)

fix some error

* add update last step ID mapper function

* bug fix

* add new console ui resource

* tune sql script version

* fix select task sql bug

* remove job list condition at debugging

* fix  unit test error

Co-authored-by: gaoxinxing <15931259256@163.com>
Co-authored-by: renyanda <781905270@qq.com>
dreamlandliu pushed a commit to dreamlandliu/starwhale that referenced this pull request Aug 25, 2022
…le#969)

* tune job and task impl

* feat(controller): add job token & storage env for job  (star-whale#940)

job token env;s3 env

* add project info for task

* add env for k8s core container

* test(e2e): modify e2e deployment from docker compose to minikube (star-whale#948)

e2e test

* feat(controller): storage prefix env (star-whale#941)

swds path prefix injection

Co-authored-by: star <15031259256@163.com>

* fix(controller): fix dataset upload error (star-whale#958)

* error fix

* fix protocol un match error

Co-authored-by: star <15031259256@163.com>

* change task container entrypoint

* fix(controller): fix sql error (star-whale#977)

fix some error

* add update last step ID mapper function

* bug fix

* add new console ui resource

* tune sql script version

* fix select task sql bug

* remove job list condition at debugging

* fix  unit test error

Co-authored-by: gaoxinxing <15931259256@163.com>
Co-authored-by: renyanda <781905270@qq.com>
@anda-ren anda-ren deleted the task_token branch September 2, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants