Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): log in with third-party account #914

Merged
merged 1 commit into from
Aug 16, 2022
Merged

feat(console): log in with third-party account #914

merged 1 commit into from
Aug 16, 2022

Conversation

jialeicui
Copy link
Contributor

Description

login.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added feature ✨ new feature console 🎨 console labels Aug 16, 2022
tianweidut
tianweidut approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit f5acd1c into star-whale:main Aug 16, 2022
@jialeicui jialeicui deleted the third-party-login branch August 16, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@waynelwz waynelwz Awaiting requested review from waynelwz

Assignees
No one assigned
Labels
console 🎨 console feature ✨ new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @tianweidut