Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): add new job impl for controller #907

Merged
merged 3 commits into from
Aug 15, 2022
Merged

feat(controller): add new job impl for controller #907

merged 3 commits into from
Aug 15, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 15, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing marked this pull request as ready for review August 15, 2022 02:44
anda-ren
anda-ren approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 847d498 into star-whale:main Aug 15, 2022
@tianweidut tianweidut changed the title feat: add new job impl for controller feat(controller): add new job impl for controller Aug 24, 2022
@goldenxinxing goldenxinxing deleted the feat/new_job_for_controller branch August 25, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anda-ren anda-ren anda-ren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @anda-ren