Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): force to close popen stdout for log_check_call #778

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix(client): force to close popen stdout for log_check_call #778

merged 1 commit into from
Jul 21, 2022

Conversation

tianweidut
Copy link
Member

Description

  • warning message:
    image
  • fixed output:
    image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Jul 21, 2022
@tianweidut tianweidut self-assigned this Jul 21, 2022
@jialeicui
Copy link
Contributor

LGTM

@jialeicui jialeicui merged commit 30c50bd into star-whale:main Jul 21, 2022
@tianweidut tianweidut deleted the fix/unclosed-open branch April 16, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

@goldenxinxing goldenxinxing Awaiting requested review from goldenxinxing

Assignees

@tianweidut tianweidut

Labels
bug 🐛 Something isn't working client 🌈 standalone 💻
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @jialeicui