Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): sw board table sortable #736

Merged
merged 1 commit into from
Jul 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 55 additions & 3 deletions client/starwhale/cli/board/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,19 @@

from rich import console
from textual import events
from rich.text import Text
from rich.style import Style
from rich.table import box, Table
from textual.app import Reactive
from textual.widget import Widget, RenderableType

from starwhale.utils import get_field, pretty_bytes, snake_to_camel
from starwhale.utils import (
Order,
get_field,
pretty_bytes,
sort_obj_list,
snake_to_camel,
)
from starwhale.consts import DEFAULT_PROJECT, STANDALONE_INSTANCE
from starwhale.core.job.view import JobTermView
from starwhale.core.model.view import ModelTermView
Expand All @@ -26,6 +33,42 @@ class Column:
render: t.Optional[t.Callable[[int, t.Any], t.Any]] = None


class OrderBy:
def __init__(self) -> None:
self.orderby_keys: t.Dict[str, str] = {
"C": "created_at",
"N": "name",
"S": "size",
}
self.current_order = Order("")

def record_key(self, key: str) -> bool:
if key not in self.orderby_keys:
return False

field = self.orderby_keys[key]
if self.current_order.field == field:
self.current_order.reverse = not self.current_order.reverse
else:
self.current_order.field = field
self.current_order.reverse = False
return True

def sort(self, data: t.Sequence):
if not self.current_order.field:
return data
return sort_obj_list(data, [self.current_order])

def get_order_icon(self) -> t.Tuple[str, RenderableType]:
if not self.current_order.field:
return "", ""
field = self.current_order.field
if self.current_order.reverse:
return field, Text(" ↓", style="green")
else:
return field, Text(" ↑", style="red")


class TableWidget(Widget):
"""TableWidget makes an interactive rich.Table"""

Expand All @@ -35,6 +78,7 @@ def __init__(self, **kwargs) -> None:
self.data: t.Sequence = []
self.render_fn: t.List[Column] = []
self._info: t.Any = None
self._orderby = OrderBy()

show_info: Reactive[bool] = Reactive(False)
cursor_line: Reactive[int] = Reactive(0, repaint=False)
Expand Down Expand Up @@ -64,10 +108,16 @@ def render(self) -> Table:
def reload(self) -> None:
self.table.columns = []
for i in self.render_fn:
self.table.add_column(i.name and i.name or snake_to_camel(i.key))
name = Text(i.name and i.name or snake_to_camel(i.key))
f, icon = self._orderby.get_order_icon()
if i.key == f:
name += icon
self.table.add_column(name)
self.reloadImpl()
self.table.rows = []
for idx, item in enumerate(self.data):

data = self._orderby.sort(self.data)
for idx, item in enumerate(data):

def try_render(col: Column):
if col.render:
Expand All @@ -88,6 +138,8 @@ def highlight_row(self, row: int) -> None:
async def on_key(self, event: events.Key) -> None:
if event.key == "r":
self.reload()
if self._orderby.record_key(event.key):
self.reload()
await self.dispatch_key(event)

async def key_down(self) -> None:
Expand Down
2 changes: 1 addition & 1 deletion client/starwhale/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def __init__(self, field: str, reverse: bool = False):
self.reverse = reverse


def sort_obj_list(data: t.List[t.Any], orders: t.List[Order]) -> t.Any:
def sort_obj_list(data: t.Sequence, orders: t.List[Order]) -> t.Any:
def cmp(a: t.Any, b: t.Any) -> int:
return (a > b) - (a < b)

Expand Down