Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): refactor agent log impl #719

Merged
merged 7 commits into from
Jul 6, 2022
Merged

refactor(log): refactor agent log impl #719

merged 7 commits into from
Jul 6, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jul 6, 2022 •
edited
Loading

Description

log

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the refactor 🐛 refactor code label Jul 6, 2022
@goldenxinxing goldenxinxing added this to the v0.3 milestone Jul 6, 2022
@goldenxinxing goldenxinxing self-assigned this Jul 6, 2022
tianweidut
tianweidut approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anda-ren
anda-ren approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut tianweidut merged commit 9527456 into star-whale:main Jul 6, 2022
@goldenxinxing goldenxinxing deleted the feat/tune_log_impl branch August 25, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@anda-ren anda-ren anda-ren approved these changes

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees

@goldenxinxing goldenxinxing

Labels
refactor 🐛 refactor code
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@goldenxinxing @tianweidut @anda-ren