Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): sort model/runtime/dataset history list by created_at field #3127

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

tianweidut
Copy link
Member

Description

  • sort history output
  • remove useless code

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09edf32) 82.86% compared to head (98b6055) 92.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3127      +/-   ##
============================================
+ Coverage     82.86%   92.27%   +9.41%     
============================================
  Files           575      139     -436     
  Lines         32125    16214   -15911     
  Branches       1873        0    -1873     
============================================
- Hits          26620    14962   -11658     
+ Misses         4676     1252    -3424     
+ Partials        829        0     -829     
Flag Coverage Δ
console ?
controller ?
standalone 92.27% <100.00%> (+0.17%) ⬆️
unittests 92.27% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit c5ce480 into star-whale:main Jan 16, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants