Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): 500 when get deleted project by name #3123

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jan 11, 2024

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (40f67ae) 82.86% compared to head (7cf1699) 73.44%.
Report is 1 commits behind head on main.

Files Patch % Lines
...e/mlops/configuration/security/JwtTokenFilter.java 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3123      +/-   ##
============================================
- Coverage     82.86%   73.44%   -9.43%     
- Complexity     3186     3188       +2     
============================================
  Files           575      433     -142     
  Lines         32086    15648   -16438     
  Branches       1870     1809      -61     
============================================
- Hits          26589    11492   -15097     
+ Misses         4669     3330    -1339     
+ Partials        828      826       -2     
Flag Coverage Δ
console ?
controller 73.44% <40.00%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit cd671cb into star-whale:main Jan 11, 2024
22 checks passed
@jialeicui jialeicui deleted the find-project branch January 11, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants