Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): dump arguments to json file when model building #3102

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jan 2, 2024

Description

depends on: #3101

image

argument json example:

{
    "evaluation:predict_image": {
        "evaluation:EvaluationArguments": {
            "reshape": {
                "name": "reshape",
                "opts": [
                    "--reshape"
                ],
                "type": {
                    "name": "integer",
                    "param_type": "INT",
                    "choices": null,
                    "case_sensitive": false
                },
                "required": false,
                "multiple": false,
                "default": 64,
                "help": "reshape image size",
                "is_flag": false,
                "hidden": false
            }
        }
    }
}

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ce80aa) 82.68% compared to head (5116c3c) 91.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3102      +/-   ##
============================================
+ Coverage     82.68%   91.84%   +9.16%     
============================================
  Files           575      139     -436     
  Lines         32062    16260   -15802     
  Branches       1865        0    -1865     
============================================
- Hits          26510    14934   -11576     
+ Misses         4726     1326    -3400     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.84% <100.00%> (+0.02%) ⬆️
unittests 91.84% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut marked this pull request as ready for review January 2, 2024 10:40
@tianweidut tianweidut marked this pull request as draft January 2, 2024 10:40
@tianweidut tianweidut force-pushed the feat/dump-args branch 2 times, most recently from 4cc1869 to 1863660 Compare January 3, 2024 10:37
@tianweidut tianweidut marked this pull request as ready for review January 3, 2024 10:41
@tianweidut tianweidut added the e2e label Jan 3, 2024
@tianweidut tianweidut force-pushed the feat/dump-args branch 2 times, most recently from 1c92d53 to 7de1113 Compare January 3, 2024 10:44
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 456f07a into star-whale:main Jan 5, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants