Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add run info to pod env #3092

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Dec 20, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added chore 🛎️ some tiny change e2e labels Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02fd459) 82.63% compared to head (bd38d6e) 73.31%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3092      +/-   ##
============================================
- Coverage     82.63%   73.31%   -9.32%     
+ Complexity     3182     3181       -1     
============================================
  Files           571      433     -138     
  Lines         31840    15629   -16211     
  Branches       1865     1804      -61     
============================================
- Hits          26312    11459   -14853     
+ Misses         4702     3347    -1355     
+ Partials        826      823       -3     
Flag Coverage Δ
console ?
controller 73.31% <100.00%> (-0.03%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 4949eea into star-whale:main Dec 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants