Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): the event request could not be deserialized #3091

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (807d59f) 82.60% compared to head (69db177) 73.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3091      +/-   ##
============================================
- Coverage     82.60%   73.35%   -9.26%     
  Complexity     3182     3182              
============================================
  Files           571      433     -138     
  Lines         31838    15625   -16213     
  Branches       1865     1804      -61     
============================================
- Hits          26301    11461   -14840     
+ Misses         4711     3341    -1370     
+ Partials        826      823       -3     
Flag Coverage Δ
console ?
controller 73.35% <ø> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit e01e84e into star-whale:main Dec 20, 2023
22 checks passed
@jialeicui jialeicui deleted the fix-event branch December 20, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants