Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): use auto generated arg_types #3089

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b19f8b2) 82.65% compared to head (8c515c2) 91.85%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3089      +/-   ##
============================================
+ Coverage     82.65%   91.85%   +9.19%     
============================================
  Files           571      135     -436     
  Lines         31832    15989   -15843     
  Branches       1873        0    -1873     
============================================
- Hits          26312    14686   -11626     
+ Misses         4694     1303    -3391     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.85% <100.00%> (+<0.01%) ⬆️
unittests 91.85% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit d72cfdb into star-whale:main Dec 19, 2023
38 checks passed
@jialeicui jialeicui deleted the auto-gen-types branch December 19, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants