Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): add env file for restored runtime #3088

Merged

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels Dec 19, 2023
@tianweidut tianweidut self-assigned this Dec 19, 2023
@tianweidut tianweidut force-pushed the enhance/activate-runtime-script-env branch from 547d0bc to 8ec4124 Compare December 19, 2023 06:56
@tianweidut tianweidut marked this pull request as ready for review December 19, 2023 06:56
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b19f8b2) 82.65% compared to head (8ec4124) 91.85%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3088      +/-   ##
============================================
+ Coverage     82.65%   91.85%   +9.20%     
============================================
  Files           571      135     -436     
  Lines         31832    15970   -15862     
  Branches       1873        0    -1873     
============================================
- Hits          26312    14670   -11642     
+ Misses         4694     1300    -3394     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.85% <100.00%> (+0.01%) ⬆️
unittests 91.85% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 02fd459 into star-whale:main Dec 20, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants