fix(client): the online evaluation is accessible behind the proxy sub-path #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3083 +/- ##
============================================
+ Coverage 82.69% 91.58% +8.88%
============================================
Files 571 138 -433
Lines 31789 16141 -15648
Branches 1873 61 -1812
============================================
- Hits 26287 14782 -11505
+ Misses 4681 1357 -3324
+ Partials 821 2 -819
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anda-ren
reviewed
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
demo: http://jialei.pre.intra.starwhale.ai/projects/1/jobs/8/servings
Bug reason: the front end can not access the assets and the APIs if the server is behind the proxy sub-path
I have implemented a simple string replacement on the client side to achieve the effects of injecting global variables and modifying asset paths.
I did not use templates like Jinja2 because once templates are used, the client/index.html file can no longer be used for debugging and packaging with Vite.
Modules
Checklist