Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix dataset copy block forever when update table meets exception #3078

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working client 🌈 labels Dec 13, 2023
@tianweidut tianweidut self-assigned this Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aad4755) 82.63% compared to head (bbce347) 91.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3078      +/-   ##
============================================
+ Coverage     82.63%   91.84%   +9.20%     
============================================
  Files           571      135     -436     
  Lines         31791    15925   -15866     
  Branches       1873        0    -1873     
============================================
- Hits          26272    14626   -11646     
+ Misses         4693     1299    -3394     
+ Partials        826        0     -826     
Flag Coverage Δ
console ?
controller ?
standalone 91.84% <100.00%> (+0.01%) ⬆️
unittests 91.84% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 411c6d8 into star-whale:main Dec 14, 2023
38 checks passed
@tianweidut tianweidut deleted the bug/dataset-copy branch December 16, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants