Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): support excludes for model build and finetune decorator #3072

Merged

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (381a2e1) 82.67% compared to head (9da4433) 91.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3072      +/-   ##
============================================
+ Coverage     82.67%   91.79%   +9.11%     
============================================
  Files           571      135     -436     
  Lines         31785    15925   -15860     
  Branches       1873        0    -1873     
============================================
- Hits          26279    14618   -11661     
+ Misses         4681     1307    -3374     
+ Partials        825        0     -825     
Flag Coverage Δ
console ?
controller ?
standalone 91.79% <100.00%> (-0.04%) ⬇️
unittests 91.79% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit bca9510 into star-whale:main Dec 12, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants