Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(sdk): add more tool methods for BoundingBox type #3068

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5cce0c) 82.62% compared to head (73e0ffe) 91.80%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3068      +/-   ##
============================================
+ Coverage     82.62%   91.80%   +9.18%     
============================================
  Files           571      135     -436     
  Lines         31761    15921   -15840     
  Branches       1872        0    -1872     
============================================
- Hits          26243    14617   -11626     
+ Misses         4694     1304    -3390     
+ Partials        824        0     -824     
Flag Coverage Δ
console ?
controller ?
standalone 91.80% <100.00%> (+0.04%) ⬆️
unittests 91.80% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 380a94b into star-whale:main Dec 8, 2023
38 checks passed
@tianweidut tianweidut deleted the enhance/bbox-methods branch December 8, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants