Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): add job create function in EvaluationService #3066

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Dec 6, 2023

Description

add job create function in EvaluationService and use it explicitly in JobCreateController so that the later refactor could be more clear

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f4c3916) 82.92% compared to head (f2ae3d1) 73.50%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ain/java/ai/starwhale/mlops/api/JobController.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3066      +/-   ##
============================================
- Coverage     82.92%   73.50%   -9.43%     
- Complexity     3167     3204      +37     
============================================
  Files           569      433     -136     
  Lines         31541    15649   -15892     
  Branches       1850     1812      -38     
============================================
- Hits          26156    11503   -14653     
+ Misses         4565     3323    -1242     
- Partials        820      823       +3     
Flag Coverage Δ
console ?
controller 73.50% <83.33%> (-0.41%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review December 6, 2023 10:57
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit e118ae4 into star-whale:main Dec 7, 2023
22 checks passed
@anda-ren anda-ren deleted the job_flatten_rf branch December 8, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants