Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): make shared boolean #3055

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft December 4, 2023 07:29
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6fc2d5) 82.93% compared to head (e752e10) 82.99%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3055      +/-   ##
============================================
+ Coverage     82.93%   82.99%   +0.06%     
  Complexity     3167     3167              
============================================
  Files           569      566       -3     
  Lines         31541    31326     -215     
  Branches       1850     1789      -61     
============================================
- Hits          26157    25999     -158     
+ Misses         4565     4509      -56     
+ Partials        819      818       -1     
Flag Coverage Δ
console ?
controller 73.91% <100.00%> (-0.01%) ⬇️
standalone 91.81% <100.00%> (-0.02%) ⬇️
unittests 91.81% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui marked this pull request as ready for review December 4, 2023 08:01
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 4ddef36 into star-whale:main Dec 4, 2023
43 checks passed
@jialeicui jialeicui deleted the bool-shared branch December 4, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants