Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): make job info --web works #3052

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 1, 2023

Description

  • Use data store built-in list table func.
  • Support gzipped response when proxy requests.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24d2acc) 82.94% compared to head (d544a9a) 91.76%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3052      +/-   ##
============================================
+ Coverage     82.94%   91.76%   +8.81%     
============================================
  Files           567      135     -432     
  Lines         31434    15888   -15546     
  Branches       1839        0    -1839     
============================================
- Hits          26074    14579   -11495     
+ Misses         4549     1309    -3240     
+ Partials        811        0     -811     
Flag Coverage Δ
console ?
controller ?
standalone 91.76% <100.00%> (-0.13%) ⬇️
unittests 91.76% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui added bug 🐛 Something isn't working client 🌈 labels Dec 1, 2023
@tianweidut tianweidut merged commit 3c1900a into star-whale:main Dec 2, 2023
38 checks passed
@jialeicui jialeicui deleted the fix-job-info branch December 3, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working client 🌈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants