Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add docker dispatched container to a network #3041

Merged
merged 7 commits into from
Nov 29, 2023

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (85c2f87) 91.68% compared to head (0a45f61) 73.90%.
Report is 8 commits behind head on main.

Files Patch % Lines
...ps/schedule/impl/docker/RunExecutorDockerImpl.java 69.23% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3041       +/-   ##
=============================================
- Coverage     91.68%   73.90%   -17.79%     
- Complexity        0     3157     +3157     
=============================================
  Files           129      430      +301     
  Lines         15277    15387      +110     
  Branches         61     1781     +1720     
=============================================
- Hits          14007    11372     -2635     
- Misses         1268     3202     +1934     
- Partials          2      813      +811     
Flag Coverage Δ
console ?
controller 73.90% <69.23%> (?)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 28, 2023 08:05
tianweidut
tianweidut previously approved these changes Nov 28, 2023
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 7695d29 into star-whale:main Nov 29, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants