Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): support pydantic v1 and v2 #3030

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (908f6d9) 82.74% compared to head (fb091ed) 91.92%.
Report is 2 commits behind head on main.

Files Patch % Lines
client/starwhale/base/models/base.py 84.61% 4 Missing ⚠️
client/starwhale/utils/json.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3030      +/-   ##
============================================
+ Coverage     82.74%   91.92%   +9.17%     
============================================
  Files           559      127     -432     
  Lines         30659    15053   -15606     
  Branches       1839        0    -1839     
============================================
- Hits          25369    13837   -11532     
+ Misses         4477     1216    -3261     
+ Partials        813        0     -813     
Flag Coverage Δ
console ?
controller ?
standalone 91.92% <92.68%> (+0.01%) ⬆️
unittests 91.92% <92.68%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui force-pushed the all-version-of-pydantic branch 3 times, most recently from f622557 to 3dc6571 Compare November 27, 2023 03:45
@tianweidut
Copy link
Member

Others LGTM

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 3395e9d into star-whale:main Nov 28, 2023
52 checks passed
@jialeicui jialeicui deleted the all-version-of-pydantic branch November 28, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants