Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: add notebook for helloworld example #3024

Merged
merged 1 commit into from
Nov 23, 2023
Merged

example: add notebook for helloworld example #3024

merged 1 commit into from
Nov 23, 2023

Conversation

tianweidut
Copy link
Member

Description

demo show: https://colab.research.google.com/drive/1kdEv66fmc_msMMwrhcgb1I-VrBpHir1d#scrollTo=yMJK3vYvBlYv

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Nov 23, 2023
@tianweidut tianweidut changed the title example: update notebook for helloworld example example: add notebook for helloworld example Nov 23, 2023
goldenxinxing
goldenxinxing approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 96f044c into star-whale:main Nov 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

@anda-ren anda-ren Awaiting requested review from anda-ren

@lijing-susan lijing-susan Awaiting requested review from lijing-susan

Assignees

@tianweidut tianweidut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @goldenxinxing